Added agent_id tracking in agent reporter collection#182
Added agent_id tracking in agent reporter collection#182AgrimGupta04 wants to merge 13 commits intomesa:mainfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Hi Agrim, thanks for the PR!
Before pushing the next commit, run the test suite locally with pytest and resolve any failures. As a hint, the current failure seems related to the shape of the DataFrame. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 92.54% 92.62% +0.07%
==========================================
Files 14 14
Lines 1717 1748 +31
==========================================
+ Hits 1589 1619 +30
- Misses 128 129 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
hey @Ben-geo & @adamamer20 its been a while since the PR is raised and further review is required from your side, kindly give it a review whenever possible. |
Hey @AgrimGupta04 While reviewing the changes, I noticed a significant number of modifications to the test cases that don’t seem necessary for the feature being added. I was also a bit confused by the overall scope of the PR. For adding a Because of this confusion, I paused the review earlier and requested a few minor changes. Unfortunately, those requested changes haven’t been implemented yet. Sorry for any confusion on my part as well. Also, please note that we are currently in the middle of a release, so this PR may not be merged until the release is completed. Could you please simplify the implementation accordingly and resolve the merge conflicts with main? |
|
okay @Ben-geo since this PR is raised from main branch I will first go ahead and raise a new PR from a featured branch & also make sure to add the required changes to the implementation. |
This PR enhances the agent data collection process by ensuring that each agent reporter includes a unique identifier, the agent_id in the collected data.
Also, agent_reporters previously collected only the values of the requested columns (eg- wealth) but now includes the unique agent_id making debugging and analysis easier.
This PR solving the issue #177